Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix backend/mlx/core and backend/common/dtypes for MLX + Improve integration_tests/numerical_test.py #19619

Draft
wants to merge 66 commits into
base: mlx
Choose a base branch
from
Draft

[WIP] Fix backend/mlx/core and backend/common/dtypes for MLX + Improve integration_tests/numerical_test.py #19619

wants to merge 66 commits into from

Commits on Apr 26, 2024

  1. Implement convolution operation for MLX backend

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9648968 View commit details
    Browse the repository at this point in the history

  2. Fix dilation_rate standardization in conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e73ec18 View commit details
    Browse the repository at this point in the history

  3. Fix validation check for input and kernel channels in conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    804a7be View commit details
    Browse the repository at this point in the history

  4. Refactor validation check for input and kernel channels in conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    00160e7 View commit details
    Browse the repository at this point in the history

  5. Refactor conv function to improve readability and fix validation checks

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f1bb716 View commit details
    Browse the repository at this point in the history

  6. Refactor _transpose_conv_kernel function to support both channels_fir… 

    …st and channels_last data formats
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    55fbace View commit details
    Browse the repository at this point in the history

  7. Refactor _transpose_conv_kernel and conv functions to improve readabi… 

    …lity and fix validation checks
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    365f48e View commit details
    Browse the repository at this point in the history

  8. Refactor numerical_test.py to support MLX backend and fix validation … 

    …checks
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    894c5d5 View commit details
    Browse the repository at this point in the history

  9. Refactor conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1b2f2bf View commit details
    Browse the repository at this point in the history

  10. Fix validation check for input and kernel channels in conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    437b7a0 View commit details
    Browse the repository at this point in the history

  11. Refactor _transpose_conv_kernel function to support both channels_fir… 

    …st and channels_last data formats
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5a62e65 View commit details
    Browse the repository at this point in the history

  12. Refactor numerical_test.py to include data_format parameter in build_… 

    …keras_model function
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a35a56c View commit details
    Browse the repository at this point in the history

  13. Refactor _transpose_conv_kernel function to support both channels_fir… 

    …st and channels_last data formats
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f6278f0 View commit details
    Browse the repository at this point in the history

  14. Refactor _transpose_conv_kernel function to handle both channels_firs… 

    …t and channels_last data formats
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4372351 View commit details
    Browse the repository at this point in the history

  15. Refactor _transpose_conv_kernel function to handle both channels_firs… 

    …t and channels_last data formats v2
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9549880 View commit details
    Browse the repository at this point in the history

  16. Refactor _transpose_conv_kernel function to handle both channels_firs… 

    …t and channels_last data formats consistently
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6514899 View commit details
    Browse the repository at this point in the history

  17. Refactor data_format parameter in conv function to use channels_last … 

    …as default value
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    682072e View commit details
    Browse the repository at this point in the history

  18. Refactor build_keras_model function in numerical_test.py to use consi… 

    …stent formatting for Conv2D layers
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6d7f5dd View commit details
    Browse the repository at this point in the history

  19. Refactor conv function to include support for groups parameter

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b96047e View commit details
    Browse the repository at this point in the history

  20. Refactor _transpose_spatial_inputs function to handle both channels_f… 

    …irst and channels_last data formats consistently
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9e25cb4 View commit details
    Browse the repository at this point in the history

  21. Refactor build_keras_model function in numerical_test.py to include i… 

    …nput_shape parameter in Conv2D layer
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9f0aa30 View commit details
    Browse the repository at this point in the history

  22. Refactor build_keras_model function in numerical_test.py to update in… 

    …put_shape parameter in Conv2D layer
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e63913d View commit details
    Browse the repository at this point in the history

  23. Refactor build_keras_model function in numerical_test.py to remove in… 

    …put_shape parameter from Conv2D layer
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a6941c1 View commit details
    Browse the repository at this point in the history

  24. fix

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b9d116d View commit details
    Browse the repository at this point in the history

  25. fix

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4390780 View commit details
    Browse the repository at this point in the history

  26. fix

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5fa46eb View commit details
    Browse the repository at this point in the history

  27. fix _transpose_spatial_inputs and _transpose_conv_kernel

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ec9ab5b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Refactor conv function for debugging

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e535415 View commit details
    Browse the repository at this point in the history

  2. Refactor conv function for better debugging

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    cea85e9 View commit details
    Browse the repository at this point in the history

  3. Refactor numerical_test.py to test channels_last

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6f4a809 View commit details
    Browse the repository at this point in the history

  4. Refactor conv v1

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    385c5a5 View commit details
    Browse the repository at this point in the history

  5. Refactor numerical_test.py to update Conv2D layer in build_keras_mode… 

    …l function
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    bdc3ef1 View commit details
    Browse the repository at this point in the history

  6. No numerical_test.py

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    c801dcc View commit details
    Browse the repository at this point in the history

  7. fix def conv

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    40ce8c9 View commit details
    Browse the repository at this point in the history

  8. Transposing kernel shape

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    9de2732 View commit details
    Browse the repository at this point in the history

  9. (C_out, C_in, H, W)

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    0d77386 View commit details
    Browse the repository at this point in the history

  10. kernel.transpose((3, 0, 1, 2))

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    66c5c70 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Refactor conv function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3ce2103 View commit details
    Browse the repository at this point in the history

  2. Update data type in numerical_test.py to float16 for testing mlx

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    929c31f View commit details
    Browse the repository at this point in the history

  3. Update back the data type in numerical_test.py to float32

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3c743f7 View commit details
    Browse the repository at this point in the history

  4. Fix dtype conversion in convert_to_tensor function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    cc207e7 View commit details
    Browse the repository at this point in the history

  5. Fix to_mlx_dtype

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6a4aa6b View commit details
    Browse the repository at this point in the history

  6. Refactor dtype conversion in to_mlx_dtype and convert_to_tensor funct… 

    …ions
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c99db80 View commit details
    Browse the repository at this point in the history

  7. Refactor dtype conversion in convert_to_tensor function

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e20dee0 View commit details
    Browse the repository at this point in the history

  8. Refactor dtype conversion in convert_to_tensor function and fix to_ml… 

    …x_dtype
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    90b0f58 View commit details
    Browse the repository at this point in the history

  9. Add debugging print statements and comments to core.py

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ae91ef9 View commit details
    Browse the repository at this point in the history

  10. Refactor dtype conversion in to_mlx_dtype and convert_to_tensor funct… 

    …ions
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    fb27c5b View commit details
    Browse the repository at this point in the history

  11. Refactor dtype conversion in convert_to_tensor function and add debug… 

    …ging print statements
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8b9331a View commit details
    Browse the repository at this point in the history

  12. Refactor dtype conversion in convert_to_tensor and to_mlx_dtype funct… 

    …ions
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6dc86da View commit details
    Browse the repository at this point in the history

  13. No /workspaces/keras/integration_tests/numerical_test.py

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    690e243 View commit details
    Browse the repository at this point in the history

  14. add debugging print statements

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    77314fe View commit details
    Browse the repository at this point in the history

  15. fix convert_to_tensor

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8e040db View commit details
    Browse the repository at this point in the history

  16. Refactor dtype conversion in convert_to_tensor and to_mlx_dtype funct… 

    …ions
    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0668b46 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Refactor dtype handle MLX

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    59c9af9 View commit details
    Browse the repository at this point in the history

  2. Refactor dtype handle MLX

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    19171b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Refactor dtype handle MLX

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    44a33ec View commit details
    Browse the repository at this point in the history

  2. Refactor dtype handling and add MLX backend support

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    62be51b View commit details
    Browse the repository at this point in the history

  3. Refactor dtype handling and add explicit handling for float8 dtypes

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7f75c3a View commit details
    Browse the repository at this point in the history

  4. comments in result_type

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    82776dd View commit details
    Browse the repository at this point in the history

  5. Add core test file for mlx

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fc78a65 View commit details
    Browse the repository at this point in the history

  6. Refactor dtype handling

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    02dc92a View commit details
    Browse the repository at this point in the history

  7. no numerical_test.py

    @Faisal-Alsrheed
    Faisal-Alsrheed committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    de83556 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. improve numerical_test.py and standardize_dtype

    @Faisal-Alsrheed
    Faisal-Alsrheed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    213a7fc View commit details
    Browse the repository at this point in the history

  2. Add DEBUGGING = True

    @Faisal-Alsrheed
    Faisal-Alsrheed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2e40687 View commit details
    Browse the repository at this point in the history

  3. Refactor numerical_test.py and variables.py

    @Faisal-Alsrheed
    Faisal-Alsrheed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c3bfdcb View commit details
    Browse the repository at this point in the history

  4. Refactor dtype handling and add MLX backend support

    @Faisal-Alsrheed
    Faisal-Alsrheed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4eb82b3 View commit details
    Browse the repository at this point in the history