Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]Support Zoom to layer in layer panel #2516

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

liuwo23
Copy link
Contributor

@liuwo23 liuwo23 commented Jan 19, 2024

Add a zoomtolayer PanelAction in the component of layer-panel-header. (The icon is temporarily using filterFunnel, and a scaling icon will need to be designed later),Then, import MapStateActions.fitBounds in the parent components and write function onZoomToLayer _zoomToLayer: MouseEventHandler = e => { e?.stopPropagation(); const bounds = this.props.layer?.meta?.bounds; bounds && this.props.zoomToLayer(bounds); };
Support #2446

@liuwo23 liuwo23 changed the title [Feat]Support Zoom to layer in layer panel [Feat]Support Zoom to layer in layer panel #2446 Jan 19, 2024
@liuwo23 liuwo23 changed the title [Feat]Support Zoom to layer in layer panel #2446 [Feat]Support Zoom to layer in layer panel Jan 19, 2024
@ibgreen
Copy link
Collaborator

ibgreen commented Jan 19, 2024

@liuwo2 Thanks for the PR. I enabled CI, seems some tests are failing. Also to pass the DCO bullet you need to sign your commit git ci --signoff

@liuwo23
Copy link
Contributor Author

liuwo23 commented Jan 22, 2024

@liuwo2 Thanks for the PR. I enabled CI, seems some tests are failing. Also to pass the DCO bullet you need to sign your commit git ci --signoff

emmm, I will attempt to resubmit and fix it.

@ibgreen
Copy link
Collaborator

ibgreen commented Jan 26, 2024

@liuwo23 Apologies for the delay, this is approved and will be landed as soon as the CI tests are green.

@liuwo23
Copy link
Contributor Author

liuwo23 commented Jan 28, 2024

@liuwo23 Apologies for the delay, this is approved and will be landed as soon as the CI tests are green.

okay

Signed-off-by: liuwo <18484922722@qq.com>
@liuwo23 liuwo23 reopened this Jan 29, 2024
@liuwo23
Copy link
Contributor Author

liuwo23 commented Jan 29, 2024

@liuwo23 Apologies for the delay, this is approved and will be landed as soon as the CI tests are green.

I recommit these changes , and replace the zoomtolayer's icon. Hope you recheck these changes.

liuwo added 3 commits January 29, 2024 22:17
Signed-off-by: liuwo <18484922722@qq.com>
Signed-off-by: liuwo <18484922722@qq.com>
Signed-off-by: liuwo <18484922722@qq.com>
@liuwo23
Copy link
Contributor Author

liuwo23 commented Feb 6, 2024

@liuwo23 Apologies for the delay, this is approved and will be landed as soon as the CI tests are green.

The tests turned green. What else needs to be passed?

@ibgreen ibgreen merged commit 0959de6 into keplergl:master Feb 6, 2024
7 checks passed
@ibgreen
Copy link
Collaborator

ibgreen commented Feb 6, 2024

The tests turned green. What else needs to be passed?

Thanks for the contribution.

PS - Our goal is to start pushing for doc updates together with PR, but we do have a big backlog of documentation and release notes, so maybe there is no obvious place for you to document this.

chrisgervang pushed a commit that referenced this pull request Feb 7, 2024
Signed-off-by: liuwo <18484922722@qq.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants