[Bug] Long Script Blocking time when adding data with WKT #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Dec 12, 2022
|
|
||
| // try parse as wkt | ||
| if (!parsedGeo) { | ||
| if (geoString.length && geoString[0] === '{') { |
There was a problem hiding this comment.
I am not exactly sure when this function is used, but generally this would not be a safe change., Strings may start with spaces and sometimes JSON geometry can be an array.
Might be better to check if the first char is an uppercase letter and if so attempt to parse as WKT.
There was a problem hiding this comment.
Great, will rewrite it 🙌
Signed-off-by: Vladi Bilonenko <bilonenko.v@gmail.com>
delfrrr
force-pushed
the
fix-blocking-when-adding-wkt
branch
from
ce3976a
to
99fcab9
Compare
|
@ibgreen any blockers to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...feature.propertiesis blocking UI for few seconds when addling large WKT files.Test datasets: big-WKT.csv.zip