[Bug] make sure the RangeBrush updates on slider range changes #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitaker-swiftnav
force-pushed
the
fix-rangeplot-handles
branch
2 times, most recently
from
364c4cc
to
4848bf5
Compare
Before this commit, if you have, e.g., a Slider with
range={[0,10]},
value={[4,5]},
, then it and its RangeBrush will look like
----||----- <- RangeBrush/histogram
====||===== <- Slider
. A bug will then appear if you change the Slider's range, say
to
range={[0,5]},
value={[4,5]},
: then you will see a situation like
----||----- <- RangeBrush (**incorrect**)
--------|-| <- Slider (correct)
where the RangeBrush has failed to update and so looks out
of sync with its Slider. This commit fixes the problem.
Signed-off-by: Jarrad Whitaker <jwhitaker-swiftnav@users.noreply.github.com>
jwhitaker-swiftnav
force-pushed
the
fix-rangeplot-handles
branch
from
4848bf5
to
8d7b404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if you have, e.g., a Slider with
, then it and its RangeBrush will look like
. A bug will then appear if you change the Slider's range, say to
: then you will see a situation like
where the RangeBrush has failed to update and so looks out of sync with its Slider. This commit fixes the problem.
Signed-off-by: Jarrad Whitaker <jwhitaker 馃摟 swift-nav.com>
I'm unable to write a test for this, sorry, because the RangeBrush fails to render at all in jsdom.
Additionally, it's admittedly unlikely, but on the offchance you'd consider a bugfix release to v2.5.5 there is a backport of this commit at https://github.com/jwhitaker-swiftnav/kepler.gl/tree/fix-rangeplot-handles-backport that applies to the
v2.5.5tag.