Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to #679 #680

Merged
merged 1 commit into from May 16, 2024
Merged

Followup to #679 #680

merged 1 commit into from May 16, 2024

Conversation

Sija
Copy link
Contributor

@Sija Sija commented May 7, 2024

No description provided.

@Sija
Copy link
Contributor Author

Sija commented May 14, 2024

@sdogruyol ping 🏓

@sdogruyol
Copy link
Member

Thanks @Sija, is this really needed? Are "text/html; charset=utf-8" and "text/html;charset=UTF-8;" different?

@Sija
Copy link
Contributor Author

Sija commented May 16, 2024

Former is canonical, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type#syntax for example

@sdogruyol
Copy link
Member

I see, thanks a lot @Sija

@sdogruyol sdogruyol merged commit 5554d3d into kemalcr:master May 16, 2024
4 checks passed
@Sija Sija deleted the patch-6 branch May 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @sdogruyol