Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Date header to HTTP responses #676

Merged
merged 5 commits into from Apr 10, 2024
Merged

Add Date header to HTTP responses #676

merged 5 commits into from Apr 10, 2024

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Apr 3, 2024

Resolves #668

Sija and others added 2 commits April 3, 2024 17:53
@Sija @Blacksmoke16
Update spec/init_handler_spec.cr
e9481ba 
Co-authored-by: George Dietrich <github@dietrich.house>
@Sija
Fix specs
abd52c9
@Sija
Copy link
Contributor Author

Sija commented Apr 3, 2024

@sdogruyol Could this be merged before the next release?

@Sija
Copy link
Contributor Author

Sija commented Apr 8, 2024

@sdogruyol Hello?

sdogruyol
sdogruyol approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Sija 🙏

@sdogruyol sdogruyol merged commit b074578 into kemalcr:master Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blacksmoke16 Blacksmoke16 Blacksmoke16 left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date Header Missing from Kemal
4 participants
@Sija @straight-shoota @sdogruyol @Blacksmoke16