Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field)!: rename props existing in native input to avoid conflict with lp #446

Merged
merged 1 commit into from
May 10, 2024

Conversation

djcouto
Copy link
Contributor

@djcouto djcouto commented May 10, 2024

BREAKING-CHANGE:
- disabled was renamed to input-disabled
- readonly was renamed to input-readonly
- required was renamed to input-required

@djcouto djcouto requested a review from a team as a code owner May 10, 2024 16:15
Copy link
Collaborator

@paulosoaresvieira paulosoaresvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like very much

@djcouto djcouto force-pushed the dc/input-disabled branch 2 times, most recently from f95d9ba to 225525b Compare May 10, 2024 16:43
@djcouto djcouto changed the title fix(text-field)!: rename prop input to input-disabled to avoid conflict with lp fix(text-field)!: rename props existing in native input to avoid conflict with lp May 10, 2024
…lict with lp

BREAKING-CHANGE:
- `disabled` was renamed to `input-disabled`
- `readonly` was renamed to `input-readonly`
- `required` was renamed to `input-required`
Copy link
Collaborator

@miguelpinto98 miguelpinto98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@djcouto djcouto merged commit 51ed823 into dev May 10, 2024
1 check passed
@djcouto djcouto deleted the dc/input-disabled branch May 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants