Merge pull request #444 from kelvininc/dc/input-disabled

fix(text-field): remove reflect on some props to avoid unwanted propagation bug
kelvininc · May 9, 2024 · 60732f8 · 60732f8
2 parents 4bcf7fc + d30e6e7
commit 60732f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../range-dates-select-dropdown/test/__snapshots__/range-dates-select-dropdown.spec.tsx.snap b/.../range-dates-select-dropdown/test/__snapshots__/range-dates-select-dropdown.spec.tsx.snap
@@ -6,7 +6,7 @@ exports[`Range Dates Input (unit tests) when uses default props should match the
     <kv-dropdown-base>
       <div class="inputs-container" slot="action">
         <div class="start-single-date-select-dropdown">
-          <kv-text-field action-icon="kv-arrow-drop-down" fit-content="" icon="kv-calendar" input-mask-regex="" placeholder="Select a start date" readonly="" state="none" type="text" value="">
+          <kv-text-field action-icon="kv-arrow-drop-down" fit-content="" icon="kv-calendar" input-mask-regex="" placeholder="Select a start date" state="none" type="text" value="">
             <mock:shadow-root>
               <kv-tooltip position="top-start" truncate="">
                 <div class="text-field-container">
@@ -38,7 +38,7 @@ exports[`Range Dates Input (unit tests) when uses default props should match the
           </kv-text-field>
         </div>
         <div class="end-single-date-select-dropdown">
-          <kv-text-field action-icon="kv-arrow-drop-down" fit-content="" icon="kv-calendar" input-mask-regex="" placeholder="Select an end date" readonly="" state="none" type="text" value="">
+          <kv-text-field action-icon="kv-arrow-drop-down" fit-content="" icon="kv-calendar" input-mask-regex="" placeholder="Select an end date" state="none" type="text" value="">
             <mock:shadow-root>
               <kv-tooltip position="top-start" truncate="">
                 <div class="text-field-container">

diff --git a/packages/ui-components/src/components/text-field/text-field.tsx b/packages/ui-components/src/components/text-field/text-field.tsx
@@ -54,15 +54,15 @@ export class KvTextField implements ITextField, ITextFieldEvents {
 	/** @inheritdoc */
 	@Prop() size?: EComponentSize = EComponentSize.Large;
 	/** @inheritdoc */
-	@Prop({ reflect: true }) disabled: boolean = false;
+	@Prop({ reflect: false }) disabled: boolean = false;
 	/** @inheritdoc */
 	@Prop({ reflect: true }) required: boolean = false;
 	/** @inheritdoc */
 	@Prop({ reflect: true }) loading: boolean = false;
 	/** @inheritdoc */
 	@Prop({ reflect: true }) state: EValidationState = EValidationState.None;
 	/** @inheritdoc */
-	@Prop({ reflect: true }) readonly: boolean = false;
+	@Prop({ reflect: false }) readonly: boolean = false;
 	/** @inheritdoc */
 	@Prop({ reflect: true }) helpText: string | string[] = [];
 	/** @inheritdoc */