use aws-sdk-v2 for ssm backend #886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should support the incoming default IMDSv2 announced by AWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
this change should add support for the upcoming default IMDSv2 as announced by AWS
Tested on a EC2 instance with and without IMDSv2 enabled, also tested with the integration test suite provided in the repository
Disclaimer:
I'm quite a beginner with golang and its module support - to keep it terse this PR currently does not include updated
vendor/nor module related files.Let me know if it looks good and I'll include those also - I could also implement the same set of changes on the
dynamodbbackend to get rid ofaws-sdk-goversion 1