Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vault lib 1.6.0 to improve performance #839

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jbsmith7741
Copy link

@jbsmith7741 jbsmith7741 commented Dec 9, 2020

started with PR #767 which added go modules.

steps to replicate go mod update

go get github.com/hashicorp/vault@v1.6.0
go get github.com/coreos/etcd@v3.3.12
go get github.com/ugorji/go@v1.1.1
go get github.com/ugorji/go/codec@none

@jbsmith7741
Copy link
Author

@kelseyhightower any chance this could get merged, It makes a big performance difference if you are using vault as a backend.

@abtreece
Copy link
Contributor

@jbsmith7741 I have been intermittently pushing my now divergent fork of this project forward as we use confd at Spreedly. I switched to go modules a couple releases ago and updated the dependencies this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants