Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #179 - Initial Jagex Launcher Support #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AustinTaylorAndrews
Copy link

I took a shot at addressing #179

The core issues that I found were:

  1. The lack of ability to launch RuneLite

When attempting to login via a RuneLite instance not launched by the Jagex Launcher, you receive an error.

  1. Window name

The window name typically was RuneLite when launched by OSBC, but the Jagex Launcher appends an account name (RuneLite - <Account Name>)

This PR creates a new bot model for OSRS, inheriting from RuneLiteBot, which will search for the Jagex Client launched RuneLite instance. It does this utilizing an account names list populated by the user.

There are also options added to the class for specifying account name directly or enabling a debug mode for additional logging/info

Note: This doesn't allow for automated launching of RuneLite via the Jagex Launcher and requires manual launching/login.
Note: This also does not create a RuneLite profile (for things like the socket plugins & configuration), so either using another, already created profile or manually creating one is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant