Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jagex Launcher support #179

Open
Tobler44 opened this issue Sep 16, 2023 · 3 comments
Open

Jagex Launcher support #179

Tobler44 opened this issue Sep 16, 2023 · 3 comments

Comments

@Tobler44
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

  • Currently for what i noticed from the code. Launching the game is reliant on user having basic osrs account and not jagex account. Game launching is impossible when user has turned their account into jagex account.

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • Solution would be to create few extra steps on launching to enable running through jagex account.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Possibly just launching the game yourself through jagex account and then selecting the launched runelite window and applying the profile needed.

Additional context
Add any other context or screenshots about the feature request here.

  • For context I am willing to give this a try myself. I finished my bachelor's in CS and I was keen on doing this sort of project myself only to find out this kind of application already exists. IF time gives, I will try to create solution myself on this problem and create pull request if possible.

as discussed in ...

@Tobler44
Copy link
Author

For what i noticed so far with the software it creates it's own instance of Runelite and refers to it via processutils. Due to non-existent documentation on the repository i've concluded my own research on the behavior.

Since Jagex Launcher doesn't allow any launch options or extra-parameters I have thought of launching Runelite as is and focus on capturing the existing process of Runelite. Making user more responsible of setting up the bot.

@Tobler44
Copy link
Author

Solution so far was to create my own model where it would simply during init take parameters set by Jagex Launcher

def init(self, bot_title, description) -> None:
super().init("RuneLite", bot_title, description, RuneLiteWindow("RuneLite"))

@Dylanttc
Copy link

Solution so far was to create my own model where it would simply during init take parameters set by Jagex Launcher

def init(self, bot_title, description) -> None: super().init("RuneLite", bot_title, description, RuneLiteWindow("RuneLite"))

hi there, would you be able to elaborate more on what you mean by creating your own model?

AustinTaylorAndrews added a commit to AustinTaylorAndrews/OS-Bot-COLOR that referenced this issue Feb 17, 2024
AustinTaylorAndrews added a commit to AustinTaylorAndrews/OS-Bot-COLOR that referenced this issue Feb 17, 2024
lucasconnellm added a commit to lucasconnellm/OS-Bot-COLOR that referenced this issue Apr 16, 2024
…xLauncherSupport

Issue kelltom#179 - Initial Jagex Launcher Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants