Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Flatpak and Snap from proxy detection warning #9740

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

droidmonkey
Copy link
Member

Need to exclude this warning for flatpak and snap distros since their proxy executable is in a unique and non-accessible location from the sandbox.

Screenshots

Oops...

image

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0eded87) 65.17% compared to head (4b6a173) 65.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9740   +/-   ##
========================================
  Coverage    65.17%   65.17%           
========================================
  Files          329      329           
  Lines        40656    40658    +2     
========================================
+ Hits         26496    26498    +2     
  Misses       14160    14160           
Files Changed Coverage Δ
src/browser/BrowserSettingsWidget.cpp 50.52% <100.00%> (+0.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey merged commit 6f14bec into develop Aug 15, 2023
11 checks passed
@droidmonkey droidmonkey deleted the fix/proxy-warning-exclude branch August 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants