Add support for Thunderbird #9706
Draft
+57
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelk83
reviewed
Aug 7, 2023
| @@ -42,8 +42,9 @@ BrowserSettingsWidget::BrowserSettingsWidget(QWidget* parent) | |||
|
|
|||
| m_ui->extensionLabel->setOpenExternalLinks(true); | |||
| m_ui->extensionLabel->setText( | |||
| tr("KeePassXC-Browser is needed for the browser integration to work. <br />Download it for %1 and %2 and %3. %4") | |||
| tr("KeePassXC-Browser is needed for the browser integration to work. <br />Download it for %1 and %2 and %3 and %4. %5") | |||
There was a problem hiding this comment.
Suggested change
| tr("KeePassXC-Browser is needed for the browser integration to work. <br />Download it for %1 and %2 and %3 and %4. %5") | |
| tr("KeePassXC-Browser is needed for the browser integration to work. <br />Download it for %1, %2, %3, %4, %5") |
Or maybe split this to one line per link?
|
Why do we use that name for the extension if we make it official? I would prefer keepassxc-mail@keepassxc.org. Perhaps it's also time to drop the -Browser or -Mail suffix entirely and simply name it "KeePassXC[ for Firefox|Chrome|Edge|Thunderbird]". |
If would prefer that too. And this is why the PR is only a draft :) Lots of things need to be changed. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds official support to keepassxc-mail with Mozilla Thunderbird. The implementation is using
org.keepassxc.keepassxc_mailname withkeepassxc-mail@kkapsner.deextension identifier.TODO:
Fixes #7838.
Testing strategy
Manually.
Type of change