Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with reloading and handling of externally modified db file #10612

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Commits on Apr 19, 2024

  1. Fix data loss on failed reload

    - External modifications to the db file can no longer be missed.
    
    - Fixed dialogFinished signal of DatabaseOpenDialog was not emitted when dialog was closed via the 'X' (close) button
    
    - For reloading with a modified db, an additional choice has been added to allow the user to ignore the changes in the file on disk.
    
    - User is now presented with an unlock database dialog if reload fails to open the db automatically.
      For example when the user removed the YubiKey, failed to touch the YubiKey within the timeout period, or db pw has been changed.
    
    Fixes keepassxreboot#5290
    vuurvlieg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    718485f View commit details
    Browse the repository at this point in the history
  2. Fix test-case

    vuurvlieg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    bf92abd View commit details
    Browse the repository at this point in the history
  3. Fix incorrect lambda argument

    vuurvlieg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    27390f5 View commit details
    Browse the repository at this point in the history
  4. Add test-case

    vuurvlieg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d5f7879 View commit details
    Browse the repository at this point in the history
  5. Tweak comments

    vuurvlieg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    26f4fcd View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Improve reload database message when triggered by db save

    Mark db as modified when db file is gone or invalid.
    vuurvlieg committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a0ae128 View commit details
    Browse the repository at this point in the history
  2. Prevent saving when db is being reloaded

    vuurvlieg committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d7e5493 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    225423e View commit details
    Browse the repository at this point in the history