Enable save button when not auto-saving non-data changes (#9634)

* Fix #9501 * Also fix bug where context menu did not update when entry moved to very top or bottom of list
keepassxreboot · Aug 7, 2023 · 5fb26d6 · 5fb26d6
1 parent e1482de
commit 5fb26d6
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/src/core/Database.cpp b/src/core/Database.cpp
@@ -939,6 +939,7 @@ void Database::markAsClean()
 void Database::markNonDataChange()
 {
     m_hasNonDataChange = true;
+    emit databaseNonDataChanged();
 }
 
 /**

diff --git a/src/core/Database.h b/src/core/Database.h
@@ -171,6 +171,7 @@ public slots:
     void databaseSaved();
     void databaseDiscarded();
     void databaseFileChanged();
+    void databaseNonDataChanged();
     void tagListUpdated();
 
 private:

diff --git a/src/gui/DatabaseWidget.cpp b/src/gui/DatabaseWidget.cpp
@@ -1112,6 +1112,8 @@ void DatabaseWidget::connectDatabaseSignals()
     connect(m_db.data(), &Database::modified, this, &DatabaseWidget::onDatabaseModified);
     connect(m_db.data(), &Database::databaseSaved, this, &DatabaseWidget::databaseSaved);
     connect(m_db.data(), &Database::databaseFileChanged, this, &DatabaseWidget::reloadDatabaseFile);
+    connect(m_db.data(), &Database::databaseNonDataChanged, this, &DatabaseWidget::databaseNonDataChanged);
+    connect(m_db.data(), &Database::databaseNonDataChanged, this, &DatabaseWidget::onDatabaseNonDataChanged);
 }
 
 void DatabaseWidget::loadDatabase(bool accepted)
@@ -1571,6 +1573,14 @@ void DatabaseWidget::triggerAutosaveTimer()
     QMetaObject::invokeMethod(m_autosaveTimer, "timeout");
 }
 
+void DatabaseWidget::onDatabaseNonDataChanged()
+{
+    // Force mark the database modified if we are not auto-saving non-data changes
+    if (!config()->get(Config::AutoSaveNonDataChanges).toBool()) {
+        m_db->markAsModified();
+    }
+}
+
 QString DatabaseWidget::getCurrentSearch()
 {
     return m_lastSearchText;

diff --git a/src/gui/DatabaseWidget.h b/src/gui/DatabaseWidget.h
@@ -129,6 +129,7 @@ class DatabaseWidget : public QStackedWidget
     // relayed Database signals
     void databaseFilePathChanged(const QString& oldPath, const QString& newPath);
     void databaseModified();
+    void databaseNonDataChanged();
     void databaseSaved();
     void databaseUnlocked();
     void databaseLockRequested();
@@ -254,6 +255,7 @@ private slots:
     void onEntryChanged(Entry* entry);
     void onGroupChanged();
     void onDatabaseModified();
+    void onDatabaseNonDataChanged();
     void onAutosaveDelayTimeout();
     void connectDatabaseSignals();
     void loadDatabase(bool accepted);

diff --git a/src/gui/MainWindow.cpp b/src/gui/MainWindow.cpp
@@ -442,6 +442,7 @@ MainWindow::MainWindow()
         SIGNAL(currentModeChanged(DatabaseWidget::Mode)), this, SLOT(setMenuActionState(DatabaseWidget::Mode)));
     m_actionMultiplexer.connect(SIGNAL(groupChanged()), this, SLOT(setMenuActionState()));
     m_actionMultiplexer.connect(SIGNAL(entrySelectionChanged()), this, SLOT(setMenuActionState()));
+    m_actionMultiplexer.connect(SIGNAL(databaseNonDataChanged()), this, SLOT(setMenuActionState()));
     m_actionMultiplexer.connect(SIGNAL(groupContextMenuRequested(QPoint)), this, SLOT(showGroupContextMenu(QPoint)));
     m_actionMultiplexer.connect(SIGNAL(entryContextMenuRequested(QPoint)), this, SLOT(showEntryContextMenu(QPoint)));
     m_actionMultiplexer.connect(SIGNAL(groupChanged()), this, SLOT(updateEntryCountLabel()));