Handle iframe URLs correctly #2166
Open
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When loading your branch as temporary addon I get: when trying to add the URL via the addon popup. |
|
(Aside from that error it seems to work fine though) |
|
I'll check that error too. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing URL's with the new iframe support, things are not working as planned.
Fixes:
toLowerCase(). The paths can contain uppercase letters, and we no longer rely just on domains.trimURL()to remove search part of the URL so a proper comparisons can be made.Fixes the issue mentioned in #1358 (comment).