Fix monochrome icon in Chrome when colorTheme == 'system' (MV3 fix)
#2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansundin
commented
Mar 19, 2024
varjolintu
approved these changes
Mar 30, 2024
|
It would be preferred if it could be possible to just send a request to content script and return the answer, but after looking at the issue myself this seems to be the only proper solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MV3 upgrade, the background script in Chrome does not have a
window. Attempting to use the monochrome icon when the theme issystemresults in an error.This uses the offscreen API to work around the issue. Another option is to set the "effective" theme when the options are saved. This would be a poor experience if the user changes the theme (or if their computer is set to automatically change it based on the time of day).
This doesn't close the offscreen document, which I think is ok. I think it will automatically close on its own. I think this is called a lot so it is probably good to keep it around. 馃し