Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation for Custom Starters in kedro new (#2618) #3771

Merged
merged 7 commits into from May 14, 2024

Conversation

doxenix
Copy link
Contributor

@doxenix doxenix commented Apr 2, 2024

Subject:

This pull request aims to enhance the user experience and clarity of documentation within kedro new command for custom starters. Specifically, it addresses issue #2618

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @doxenix ! Left a couple of minor comments

@doxenix doxenix requested a review from merelcht as a code owner April 3, 2024 15:41
@astrojuanlu
Copy link
Member

@doxenix There seem to be commits from other branches here, do you mind squashing everything and rebasing on top of main? There are also conflicts in the changelog.

Also remember to signoff your commit so the DCO check passes. If you click on it you will find instructions. If it was only one commit you can do git commit --amend --signoff --no-edit, if you had more, git rebase --signoff. After rewriting the history you will need to do git push --force.

And if you keep working on this branch, please use the -s/--signoff flag when committing, for example git commit -s -m 'Add feature'.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doxenix doxenix force-pushed the fix/2618 branch 2 times, most recently from 2bfa808 to dc384f7 Compare April 4, 2024 09:25
Signed-off-by: Dominik Zalewski <dominikzalewski97@gmail.com>
doxenix and others added 5 commits April 4, 2024 11:38
Signed-off-by: Dominik Zalewski <78603984+doxenix@users.noreply.github.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @doxenix

@merelcht merelcht enabled auto-merge (squash) May 14, 2024 10:46
@merelcht merelcht merged commit 360cd12 into kedro-org:main May 14, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants