Disable rich markup if rich handler is not present #3682
Conversation
Signed-off-by: Simon Brugman <sbrugman@users.noreply.github.com>
| def has_rich_handler(logger: logging.Logger) -> bool: | ||
| """Returns true if the logger has a RichHandler attached.""" | ||
| return any(isinstance(handler, RichHandler) for handler in logger.handlers) | ||
|
|
There was a problem hiding this comment.
Is it possible to save this result to avoid calling this hundred times? It's probably have insignificant performance cost.
There was a problem hiding this comment.
Added functools.cache (if we assume the logger is not modified at runtime).
It's also possible to cache it on the DataCatalog in this case.
Side questions: has there been any profiling of Kedro? What are the most expensive parts of the framework?
There was a problem hiding this comment.
@sbrugman Sorry I missed the notification. I think it depends on what you are targeting.
#1476 is trying to optimise the CLI performance, those are insignificant time for a kedro run but significant for CLI UX.
For a kedro run, "it depends". The slowest one is always the node computation itself or the dataset I/O. Kedro itself does not have too much penalty, it can be even faster than a script if you can use some of the tricks to speed up (parallel runner, async I/O etc).
The main "penalty" I would say is saving & loading the same data, which could be reduced by using CacheDataset or something similar to avoid the unnecessary loading/blocking time.
|
I would like this to go in please |
Description
Fix for #3626
Only used in Data Catalog (2x)
Done in Github UI to start the discussion.
Will add unit tests, and add release notes.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile