Misc: attempt to reduce carries

[sttts]

No description provided.

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sttts]

/hold

[kcp-ci-bot]

@sttts: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-everything	e3640a6	link	true	/test pull-controller-runtime-everything

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[xrstf]

Can you describe in one or two sentences what this PR does? You remove some fields like NewAPIReader, I presume those are now upstream or not needed anymore, because of some refactoring?

[sttts]

@xrstf tried to minimize the changes. NewAPIReader is replaced wth newClient. We reuse the private variable (this is the ugly part). Is it worth it? Not sure. Clearly smaller, but also a bit uglier.

[xrstf]

pkg/kcp/wrappers.go:73:70: directive // nolint:gosec // this is safe should be written without leading space as //nolint:gosec // this is safe (nolintlint)
fieldPointer := (*F)(unsafe.Pointer(newInformerField.UnsafeAddr())) // nolint:gosec // this is safe

Doesn't look like a flake.

[kcp-ci-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.