New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: advance resolver incremental compile #1209
Draft
He1pa
wants to merge
4
commits into
kcl-lang:main
Choose a base branch
from
He1pa:advance_resolver_cache
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
Apr 9, 2024
He1pa
changed the title
feat: advance resolver incremental compile
[wip]feat: advance resolver incremental compile
Apr 10, 2024
He1pa
changed the title
[wip]feat: advance resolver incremental compile
feat: advance resolver incremental compile
Apr 12, 2024
He1pa
force-pushed
the
advance_resolver_cache
branch
from
April 12, 2024 06:27
0aeaf12
to
6b8d04c
Compare
Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
advance_resolver_cache
branch
from
April 12, 2024 06:31
6b8d04c
to
d7bb85a
Compare
Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
advance_resolver_cache
branch
from
April 12, 2024 06:44
d7bb85a
to
29bfa67
Compare
Pull Request Test Coverage Report for Build 9028982239Details
💛 - Coveralls |
Peefy
reviewed
Apr 12, 2024
gs: GlobalState, | ||
node_ty_map: NodeTyMap, | ||
) -> GlobalState { | ||
gs: &'ctx mut GlobalState, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit strange here that all stateful state variables are not unified, some are Arc<Mutex<T>>
, some are Rc<RefCell<T>>
, and some are &mut
borrowing. Should they all be unified as Arc<Mutex<T>
, corresponding to the multi-threaded scenario of the language server.
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
advance_resolver_cache
branch
from
May 10, 2024 07:41
cea07d0
to
a8f1b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
sema/src/advanced_resolver
sema/src/core
sema/src/resolver
tools/src/LSP
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
advance resolver incremental compile
invalidate_pkgs
in resolverinvalidate_pkgs
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: