Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Updates #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Multiple Updates #134

wants to merge 1 commit into from

Conversation

calumk
Copy link

@calumk calumk commented May 2, 2022

Multiple Updates

  • Added Linenumber add / remove
  • Added Linenumber toggle
  • Added Readonly toggle
  • Added support to destroy/dispose of the editor
    • Requires the modification from anon to named functions for the event listeners

Solves

#132 - Enable/Disable Line numbers
#107 - Destroy

Fixes

#133


toggleReadonlyMode() : Toggles the ReadOnly Mode

enableLineNumbers() : Enables (Shows) Line numbers
disableLineNumbers() : Disables (Hides) Line numbers
toggleLineNumbers() : Toggle the state of the line numbers

dispose() : Destroys the Instance, and destroys event listeners.

@Axinet
Copy link

Axinet commented Nov 1, 2022

@kazzkiq any chances to accept this pull request? It looks like a valuable improvements to the editor. Errors reported in Travis CI build look rather like environment related, not code related (although I may be wrong, so please check if some config in workflows is required, or indeed there is some mistakes in @calumk code).

@calumk
Copy link
Author

calumk commented Nov 17, 2023

I have re-released this and provided updates at : https://github.com/calumk/codeCup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants