Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to create keys from certificate private keys #5

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pschou
Copy link

@pschou pschou commented Sep 18, 2022

This PR allows your tool to create ppk files from a given private key. I also rounded out the ability to read, write, and verify all the putty version formats (SSH1 1.1, and the more current 1,2, and 3).

@kayrus
Copy link
Owner

kayrus commented Sep 18, 2022

Thanks for the PR. It's quite a big change and I need a bigger free time slot to review it.

Copy link
Owner

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the first code review. The rest will submit later.

dsa.go Outdated Show resolved Hide resolved
marshal.go Outdated Show resolved Hide resolved
marshal.go Outdated Show resolved Hide resolved
marshal.go Show resolved Hide resolved
marshal.go Outdated Show resolved Hide resolved
putty.go Outdated Show resolved Hide resolved
putty.go Outdated Show resolved Hide resolved
putty.go Outdated Show resolved Hide resolved
putty.go Outdated Show resolved Hide resolved
putty.go Outdated Show resolved Hide resolved
@pschou
Copy link
Author

pschou commented Sep 18, 2022

@kayrus I am sorry for the go test not passing on the PR on the first submission. I thought I had pushed my latest change on disk and blindly did the PR before doing the commit and push. I appreciate your patience. The test should be good now!

@pschou
Copy link
Author

pschou commented Oct 1, 2022

@kayrus: Just a heads up here, I finished implementing the SSH1 read and writing routines, so this library can thoroughly read and write every possible putty key format!

All the best!

@kayrus
Copy link
Owner

kayrus commented Jul 20, 2023

@pschou I apologies for the delay. Could you please rebase your branch to resolve the conflicts? I'll try to review this PR ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants