Updated README, remove duplicate Open Graph tags, SEO optimization, featured image and more #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjbrg
commented
Jan 14, 2022
•
sjbrg
commented
- I've suggested an updated readme to reflect that this theme supports Ghost v4.
- I've also suggested removal of the duplicate Open Graph tags that this theme generates, since Ghost generates them natively since 2018.
- I've added internationalisation support and also included a swedish theme translation
- Optimized h1 tag for site title so it only has h1 tag on the homepage. On other pages it is a regular span, to give more weight to the post title.
- Optimized post title h3 tags. I broke out the post meta (date and tags) from the h3 tag so it only contains the post title. Improves SEO.
Changed "Last tested" to Ghost v4.
The tags og:title, og:type and og:description are populated by Ghost natively, so no need for the theme to do it.
Changed so the site title H1 tag is only used on the homepage. On other pages / posts the site title is a span with identical styling, which gives more weight to the actual topic of the page that you likely want to rank for in search engines.
Added support for theme internationalization, as well as swedish translation.
sjbrg
changed the title
sjbrg
changed the title
I've broken out the post meta (date and tags) from the h3 title tag so that it only includes the actual post title. Best practice for SEO-purposes. Also added CSS to keep styling identical. On small screens the post meta is placed underneath the page title to avoid ugly line breaks.
I'd suggest adding support for custom excerpt. One might think it takes away from the "minimalist"-approach of this theme, but even if it's supported you don't have to use it. And at least for me who have used custom excerpts with my previous theme this allowed me (and will help others) to take the jump and try out Crisp without loosing that content.
For the same reason as suggesting support for custom excerpt is added, I would suggest support for featured images is added. I have featured images on most of my posts and when I switched to Crisp I "lost" those images. Adding support gives people the option to use it if they want. This featured image code is borrowed from the default Casper theme.
Replaced hardcoded link color with with the native accent color variable to use the accent color that's set in the Ghost design settings.
|
sjbrg
changed the title
Updated to set lang code according to setting in Ghost settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.