addresses #578 - use dplyr::select insstead of select_ #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, this is the same person that opened the issue here, just on a different account. I don't mean to confuse. I was having trouble with that account |
kassambara
requested changes
Feb 14, 2023
R/ggsurvplot_combine.R
Outdated
Comment on lines
164
to
165
| dplyr::select(strata, time, n.risk, pct.risk, n.event, cum.n.event, | ||
| n.censor, cum.n.censor, strata_size) |
There was a problem hiding this comment.
To avoid R cmd check warning, quotes are needed around variables. The code should look like this:
dplyr::select( dplyr::all_of(c("strata", "time", "n.risk", "pct.risk",
"n.event", "cum.n.event", "n.censor",
"cum.n.censor", "strata_size")))
R/surv_median.R
Outdated
| @@ -59,7 +59,7 @@ surv_median <- function(fit, combine = FALSE){ | |||
| .table$strata <- rownames(.table) | |||
|
|
|||
| .table <- .table %>% | |||
| dplyr::select_(.dots = c("strata", "median", "`0.95LCL`", "`0.95UCL`")) | |||
| dplyr::select(strata, median, `0.95LCL`, `0.95UCL`) | |||
There was a problem hiding this comment.
As above (to avoid R check warnings), the code should be:
dplyr::select(dplyr::all_of(c("strata", "median", "0.95LCL", "0.95UCL")))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also related to #460 , #577, #509, and #546
there are two ways to fix this select warning
!!!symsin front of the vector like Fix for dplyr 1.0.0 #460I chose 1 because I think it's simpler
I also added a test