Remove parallel CUDA streams while keeping main_stream and loss_event(?) #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on Discord, I think whatever we eventually architect that's better than my naive folly will probably still need something similar to "main_stream" that's the default for everything, so I kept that (and added it for the one kernel where it was missing)
Also loss_event is a good example of something that kinda works as intended and it allows forward and backward to overlap, so kept it for now, to show this CPU/GPU parallelism can work even with just a single "main_stream" (we should be able to do the same for the main loop to avoid syncing for timing). But it'd be good to abstract it in a safer way somehow, so definitely wouldn't disagree if you wanted to remove it too!