Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallel CUDA streams while keeping main_stream and loss_event(?) #417

Closed
wants to merge 2 commits into from

Conversation

ademeure
Copy link
Contributor

See discussion on Discord, I think whatever we eventually architect that's better than my naive folly will probably still need something similar to "main_stream" that's the default for everything, so I kept that (and added it for the one kernel where it was missing)

Also loss_event is a good example of something that kinda works as intended and it allows forward and backward to overlap, so kept it for now, to show this CPU/GPU parallelism can work even with just a single "main_stream" (we should be able to do the same for the main loop to avoid syncing for timing). But it'd be good to abstract it in a safer way somehow, so definitely wouldn't disagree if you wanted to remove it too!

@karpathy
Copy link
Owner

I merged a version of this earlier, closing

@karpathy karpathy closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants