Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added svg inlining (not clean) ==> pull request #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frosini
Copy link

@frosini frosini commented Nov 30, 2020

Hi @karolzak

Thanks for your answer.

This change requires urllib package (to convert the svg file in a less ambiguous way, otherwise the svg code was messing with the html). I did minimal changes to one function without changing the user functions, as i didn't want to mess with the rest of the package yet.

Please tell me if you want me to do it (i'm really afraid to do something wrong as it's the first time i do a pull request :)).

Best,

Mikael

Edit: sorry that all the tests failed, i overlooked a lot of things it seems

@karolzak karolzak linked an issue Nov 30, 2020 that may be closed by this pull request
@karolzak karolzak added this to In progress in Continuous improvements Dec 9, 2020
@karolzak karolzak moved this from In progress to Review in Continuous improvements Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Inlining svg files
1 participant