Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Inlining svg files #24

Open
frosini opened this issue Nov 28, 2020 · 1 comment · May be fixed by #25
Open

[Feature request] Inlining svg files #24

frosini opened this issue Nov 28, 2020 · 1 comment · May be fixed by #25
Labels
enhancement New feature or request

Comments

@frosini
Copy link

frosini commented Nov 28, 2020

Hi,

Thanks for your work, your package is just super convenient to work with.

I wanted to suggest the possibility to authorize svg inlining inside the html. SVG is convenient for scientific visualization (as most figures created with matplotlib or Tickz are vectorized) and a good alternative to f_64 conversion that induced a loss of resolution in my case when resizing. Usual inclusion with relative or absolute path was also not convenient as i needed to share the notebook with collaborators, and sending them the figures separately created more problems than solutions.

It took me a few lines to add the functionality locally but i figured other people could have the same needs. I'd be happy to it send to you if you'd like.

Cheers,

Mikael

@karolzak
Copy link
Owner

Hi @frosini ! Glad you find ipyplot useful!

This is actually a great idea for a new feature! Would love to see your local fix for that. Can you make a pull request with your changes (it doesn't have to be clean - we can improve it later)?
Thanks,
Karol

@karolzak karolzak added the enhancement New feature or request label Nov 30, 2020
@karolzak karolzak linked a pull request Nov 30, 2020 that will close this issue
@karolzak karolzak added this to In progress in Continuous improvements Dec 9, 2020
@karolzak karolzak moved this from In progress to Review in Continuous improvements Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants