fix incompatible 1.18 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: panguicai008 <1121906548@qq.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/XS
|
/cc @RainbowMango |
|
/cc @RainbowMango |
|
/assign @XiShanYongYe-Chang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/kind bug
When I execute the
make dev-envcommand to deploy, an error is reported at line 100 of the dev-env script, prompting that the version of kubernetes 1.18 is incompatible. Through checking the relevant code of the helm github repo, we know that when thehelm templatecommand is executed, the mock data will be used for verification. The mock needs to specify the version of the kubernetes for compatibility. Under the version 3.5 of Helm, kubernetes 1.18 will be used for verification.reference：
https://github.com/helm/helm/blob/release-3.4/pkg/chartutil/capabilities.go#L34
https://github.com/helm/helm/blob/release-3.5/pkg/chartutil/capabilities.go#L32
The deployed chart must be greater than or equal to 1.19.
reference：
https://github.com/karmada-io/multi-cluster-ingress-nginx/blob/main/charts/ingress-nginx/Chart.yaml#L19
so i need to find a version of Helm that is compatible with 1.19. The minimum version is helm3.5