-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy list with rv=0 no longer access member cluster etcd #4896
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Run karmada-search with
From the logs, we can see that both two member clusters are accessed with ResourceVersion:"0". |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4896 +/- ##
==========================================
- Coverage 53.12% 53.11% -0.02%
==========================================
Files 251 251
Lines 20417 20422 +5
==========================================
Hits 10847 10847
- Misses 8856 8860 +4
- Partials 714 715 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @ikaven1024 , please assign this to @XiShanYongYe-Chang or me once it's ready for review. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When client request list with rv=0, proxy fetch objects from cache. It works as expected.
While when pagination occurs, a
continue
will be responsed. This continue will filled with cluster's versions.karmada/pkg/search/proxy/store/multi_cluster_cache.go
Line 295 in 02dad48
And the next paging request will access etcd with version in
continue
. We should make it accessing cache also to improve performance.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: