Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e for WorkloadRebalancer #4869

Merged
merged 1 commit into from May 18, 2024
Merged

add e2e for WorkloadRebalancer #4869

merged 1 commit into from May 18, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Apr 25, 2024 •
edited

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for WorkloadRebalancer

Which issue(s) this PR fixes:

Fixes part of #4840

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (6cfed59) to head (9211d27).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4869      +/-   ##
==========================================
+ Coverage   53.19%   53.24%   +0.05%     
==========================================
  Files         252      252              
  Lines       20509    20514       +5     
==========================================
+ Hits        10909    10923      +14     
+ Misses       8880     8868      -12     
- Partials      720      723       +3
Flag Coverage Δ
unittests 53.24% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju mentioned this pull request Apr 25, 2024
Open
@chaosi-zju
Copy link
Member Author

/hold

for #4875

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@chaosi-zju chaosi-zju force-pushed the reschedule-e2e1 branch 4 times, most recently from 7852732 to 385aec2 Compare May 7, 2024 12:35
@chaosi-zju
Copy link
Member Author

cc @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 11, 2024
View reviewed changes
test/e2e/workloadrebalancer_test.go Outdated Show resolved Hide resolved
test/e2e/workloadrebalancer_test.go Outdated Show resolved Hide resolved
test/e2e/workloadrebalancer_test.go Outdated Show resolved Hide resolved
test/e2e/workloadrebalancer_test.go Outdated Show resolved Hide resolved
test/e2e/workloadrebalancer_test.go Outdated Show resolved Hide resolved
test/e2e/framework/resourcebinding.go Outdated Show resolved Hide resolved
test/e2e/framework/resourcebinding.go Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

@XiShanYongYe-Chang comments all fixed.

@chaosi-zju
add e2e for WorkloadRebalancer
9211d27 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@chaosi-zju
Copy link
Member Author

comment all fixed, review can going on~

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 18, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2024
@XiShanYongYe-Chang
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2024
@karmada-bot karmada-bot merged commit 35d3d85 into karmada-io:master May 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chaosi-zju @codecov-commenter @XiShanYongYe-Chang @karmada-bot @RainbowMango