fixes for windows #103
Open
fixes for windows #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @karan,
I love this tool. I've been using it for as long as I can remember. Thanks so much for making it (and also thanks for rewriting this in Go!)
I noticed that when I downloaded the executable from the releases page, I was getting an error about the system not being able to find
/tmp/master.zip, which makes sense because I'm on a windows machine. I tweaked it a little bit and added an extra library to determine where the home directory is based on the users machine. It works on my windows box now, but I wasn't able to test it on a Darwin or Linux machine yet.Here's the PR - sorry about all the whitespace changes, my formatter ran a train on it. :/
Thanks again!