Skip to content

Commit 1273c60

Browse files
committed
Enhancements - top menu updated, bug fixes
1 parent 16c1bae commit 1273c60

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,5 @@ TestResult.xml
5858
*.env
5959

6060
#files#
61-
project.lock.json
61+
package-lock.json
6262
src/server/web-variables.env

pending_changes.txt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
1. a localStorage for preferences. If it is not set, it will consider as a first visit and welcome the user with options to set
2-
preferences. A search will done with keywords and load in home page.
3-
2. When click on user info area and if it is not from home page, there is an issue that it will redirect to home page.
4-
3. Add color indicator for different shopping sites (Flipkart, Amazon, Ebay).
5-
4. The scroll should be done in scroll area. It should not scroll the entire page. That means header and search box must remains there.
6-
5. There must be a progress indicator while loading the items.
7-
6. Compare this feature.
8-
7. Offers and deal of the day are caching. What if the caching failed? will it try to fetch from web service next loading?
1+
1. When click on user info area and if it is not from home page, there is an issue that it will redirect to home page.
2+
2. Compare this feature.
3+
3. Offers and deal of the day are caching. What if the caching failed? will it try to fetch from web service next loading?

src/app/account/top-menu.component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,17 @@ import { AccountService } from "../services/account/account.service";
1010
selector: "[topMenu]",
1111
template: `
1212
<li *ngIf="!isLogged" ngbDropdown>
13-
<a href="#" id="anonymousMenu" class="nav-link" ngbDropdownToggle>Hi Guest&nbsp;<span class="glyphicon glyphicon-triangle-bottom"></span></a>
13+
<a id="anonymousMenu" class="nav-link lnk" ngbDropdownToggle>Hi Guest&nbsp;<span class="glyphicon glyphicon-triangle-bottom"></span></a>
1414
<div ngbDropdownMenu aria-labelledby="anonymousMenu">
15-
<a href="#" class="dropdown-item menu-link" [routerLink]="['/signin']" routerLinkActive="active">Signin</a>
15+
<a href="#" class="dropdown-item menu-link" [routerLink]="['/dashboard']" routerLinkActive="active">Dashboard</a>
16+
<a href="#" class="dropdown-item menu-link" [routerLink]="['/signin']">Signin</a>
1617
<a href="#" class="dropdown-item menu-link" (click)="showPreference()">Preferences</a>
1718
</div>
1819
</li>
1920
<li *ngIf="isLogged" ngbDropdown>
20-
<a href="#" id="accountMenu" class="nav-link" ngbDropdownToggle>Welcome&nbsp;{{info.name}}&nbsp;<span class="glyphicon glyphicon-triangle-bottom"></span></a>
21+
<a id="accountMenu" class="nav-link lnk" ngbDropdownToggle>Welcome&nbsp;{{info.name}}&nbsp;<span class="glyphicon glyphicon-triangle-bottom"></span></a>
2122
<div ngbDropdownMenu aria-labelledby="accountMenu">
23+
<a href="#" class="dropdown-item menu-link" [routerLink]="['/dashboard']" routerLinkActive="active">Dashboard</a>
2224
<a href="#" class="dropdown-item menu-link" (click)="showPreference()">Preferences</a>
2325
<a href="#" class="dropdown-item menu-link" [routerLink]="['/wishlist']">Wishlist <span class="glyphicon glyphicon-heart float-right"></span></a>
2426
<a href="#" class="dropdown-item menu-link" (click)="logout()">Sign Out <span class="glyphicon glyphicon-log-out float-right"></span></a>

src/app/app.routing.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ const appRoutes: Routes = [
1111
path: "",
1212
component: HomeComponent
1313
},
14+
{
15+
path: "dashboard",
16+
component: HomeComponent
17+
},
1418
{
1519
path: "signin",
1620
component: SigninComponent

src/app/shared/styles/styles.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,7 @@ input:checked + .slider:before {
9191
-ms-transform: translateX(8px);
9292
transform: translateX(8px);
9393
}
94+
95+
.lnk {
96+
cursor: pointer;
97+
}

0 commit comments

Comments
 (0)