fixes: STATIC_URL is hardcoded in read-view & nginx.conf (docker) #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the STATIC_URL is hardcoded in
nginx.conf
and thecustom-read.py
. It would be helpfull to be able to configure the STATIC_URL to something different than/static/
through the whole stack (the app-container and the nginx-container - without touching 2 different files).For illustrations: I am using Apache's SSLProxyEngine to masquerade different internal docker-/app-containers via a public URL like in the following (
/reminiscence_static/
is for the static-files served by the nginx-container,/reminiscence/
represents the ROOT_URL_LOCATION of Reminiscence and leads to the web-container here, the/static/
-URL instead is use for another app running on the same server/virtual-host entry):This patch adresses this.
Greetings,
Sven