Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: STATIC_URL is hardcoded in read-view & nginx.conf (docker) #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

s3h10r
Copy link
Contributor

@s3h10r s3h10r commented Jun 1, 2020

Hi,
the STATIC_URL is hardcoded in nginx.conf and the custom-read.py. It would be helpfull to be able to configure the STATIC_URL to something different than /static/ through the whole stack (the app-container and the nginx-container - without touching 2 different files).

For illustrations: I am using Apache's SSLProxyEngine to masquerade different internal docker-/app-containers via a public URL like in the following (/reminiscence_static/ is for the static-files served by the nginx-container, /reminiscence/ represents the ROOT_URL_LOCATION of Reminiscence and leads to the web-container here, the /static/-URL instead is use for another app running on the same server/virtual-host entry):

    SSLProxyEngine On

    ProxyPass /reminiscence/ http://n.n.n.n:8100/reminiscence/
    ProxyPassReverse /reminiscence/ http://n.n.n.n:8100/reminiscence/
    ProxyPass /reminiscence_static/ http://n.n.n.n:8100/reminiscence_static/
    ProxyPassReverse /reminiscence_static/ http://n.n.n.n:8100/reminiscence_static/

This patch adresses this.

Greetings,
Sven

@kanishka-linux
Copy link
Owner

Hey thanks, I'll surely look into it in the weekends

@kanishka-linux
Copy link
Owner

As these are code changes, won't it be better to have some tests around these changes?

@s3h10r
Copy link
Contributor Author

s3h10r commented Jun 8, 2020

Hi, sure. Don't have time at the moment but will look into writing tests for it. Greetings, Sven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants