WIP: Issue 668 #797
Draft
WIP: Issue 668 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this isn't ready to merge, could you please turn it a draft? |
Firstyear
reviewed
May 30, 2022
Firstyear
reviewed
May 30, 2022
| @@ -555,7 +553,8 @@ pub fn create_https_server( | |||
| .post(oauth2_id_scopemap_post) | |||
| .delete(oauth2_id_scopemap_delete); | |||
|
|
|||
| let mut self_route = appserver.at("/v1/self"); | |||
| // TODO(mea): self -> whoami? | |||
There was a problem hiding this comment.
The "whoami" is just a reflector of details about the currently authenticated user. This is a bit of a "hold-over" from the past, where the auth-bearer tokens used to be opaque, so they couldn't be client-side introspected.
However, recently we have changed these so they CAN be client side introspected, meaning it's possible that we may NOT need the "whoami" route at all.
There was a problem hiding this comment.
The lines around here:
https://github.com/kanidm/kanidm/blob/master/kanidm_tools/src/cli/common.rs#L115
You could use "uat.uuid" instead which gives you the ID of the token holder, since the tokens are JWT's internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started looking at the code today. Will push my work incrementally to this PR.
Fixes #668