New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Don't try and store/serialize the instance as an empty name #2741
Draft
yaleman
wants to merge
28
commits into
kanidm:master
Choose a base branch
from
yaleman:yaleman/issue2740
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaleman
commented
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error on logout:
2024-05-01T23:44:59.097647Z ERROR kanidm_cli::session: Unable to access token public key
2024-05-01T23:44:59.097654Z TRACE kanidm_cli::session: Using jwsc: JwsCompact { header: ProtectedHeader { alg: ES256, jku: None, jwk: None, kid: Some("7de88406403451e6bdd9bd43c45401db"), crit: None, typ: None, cty: None, x5u: None, x5c: None, x5t: None, x5t_s256: None, ctx: None }, payload: "eyJzZXNzaW9uX2lkIjoiYTczNWEyYzItZGI2Yi00ZmIwLWI4OWMtMGU2OTNhZWQ1MjI5IiwiaXNzdWVkX2F0IjoxNzE0NjA3MDkzLCJleHBpcnkiOjE3MTQ2MTA2OTMsInB1cnBvc2UiOnsicmVhZHdyaXRlIjp7ImV4cGlyeSI6MTcxNDY5MzQ5M319LCJ1dWlkIjoiMDAwMDAwMDAtMDAwMC0wMDAwLTAwMDAtMDAwMDAwMDAwMDE4IiwiZGlzcGxheW5hbWUiOiJJRE0gQWRtaW5pc3RyYXRvciIsInNwbiI6ImlkbV9hZG1pbkBsb2NhbGhvc3QiLCJtYWlsX3ByaW1hcnkiOm51bGwsInVpX2hpbnRzIjpbXSwibGltaXRfc2VhcmNoX21heF9yZXN1bHRzIjpudWxsLCJsaW1pdF9zZWFyY2hfbWF4X2ZpbHRlcl90ZXN0IjpudWxsfQ" }
2024-05-01T23:44:59.097670Z TRACE kanidm_cli::session: Using token: "eyJhbGciOiJFUzI1NiIsImtpZCI6IjdkZTg4NDA2NDAzNDUxZTZiZGQ5YmQ0M2M0NTQwMWRiIn0.eyJzZXNzaW9uX2lkIjoiYTczNWEyYzItZGI2Yi00ZmIwLWI4OWMtMGU2OTNhZWQ1MjI5IiwiaXNzdWVkX2F0IjoxNzE0NjA3MDkzLCJleHBpcnkiOjE3MTQ2MTA2OTMsInB1cnBvc2UiOnsicmVhZHdyaXRlIjp7ImV4cGlyeSI6MTcxNDY5MzQ5M319LCJ1dWlkIjoiMDAwMDAwMDAtMDAwMC0wMDAwLTAwMDAtMDAwMDAwMDAwMDE4IiwiZGlzcGxheW5hbWUiOiJJRE0gQWRtaW5pc3RyYXRvciIsInNwbiI6ImlkbV9hZG1pbkBsb2NhbGhvc3QiLCJtYWlsX3ByaW1hcnkiOm51bGwsInVpX2hpbnRzIjpbXSwibGltaXRfc2VhcmNoX21heF9yZXN1bHRzIjpudWxsLCJsaW1pdF9zZWFyY2hfbWF4X2ZpbHRlcl90ZXN0IjpudWxsfQ.cJbwnCim1ThybqOHC8l5mFeob0tgXY9KdG9vz0wze8pN5KN0YqdNYMi9e_Qv_RQ2EZH1QyKP9bH1YSDX5xdJvg"
yaleman
commented
May 2, 2024
Ok(verifier) => verifier, | ||
Err(err) => { | ||
error!(?err, "Unable to configure jws verifier"); | ||
std::process::exit(1); | ||
} | ||
}, | ||
None => { | ||
// TODO: this is failing due to some issue I don't *quite* understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Firstyear this one's breaking and I'm not sure why yet
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the logout functionality's not working, fails to load the token's public key from the store.
relates to #2740
fixes #2743
Checklist