Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookstack #2666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bookstack #2666

wants to merge 2 commits into from

Conversation

phoenixbackups
Copy link

Fixes #

Checklist

  • [ * ] This pr contains no AI generated code
  • [ X ] cargo fmt has been run
  • [ X ] cargo clippy has been run
  • [ X ] cargo test has been run and passes
  • [ * ] book chapter included (if relevant)
  • [ * ] design document included (if relevant)

Firstyear
Firstyear requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should be in /book/src/examples/bookstack.md, and in book/src/SUMMARY.md should have a link to this in the example section.

tumbl3w33d
tumbl3w33d reviewed Mar 19, 2024
View reviewed changes
examples/bookstack.md

### 6. Disable PKCE / Enable Legacy crypto
```
kanidm system oauth2 warning-insecure-client-disable-pkce bookstack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to disable PKCE anymore. See BookStackApp/BookStack#4734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumbl3w33d tumbl3w33d tumbl3w33d left review comments

@Firstyear Firstyear Firstyear requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Organising Everything
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phoenixbackups @Firstyear @tumbl3w33d