WIP: Webauthn-transport #1204
Draft
WIP: Webauthn-transport #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@micolous Is there any reason to leave this as WIP? we can merge it and use a dev version of webauthn-rs in this library |
|
Is this still needed @micolous ? |
|
Yeah, but I think I'll wait for kanidm/webauthn-rs#324 now |
micolous
force-pushed
the
feature/webauthn-transport
branch
from
99e9610
to
1f14c34
Compare
Firstyear
requested changes
Jul 12, 2023
| # webauthn-rs = "0.5.0" | ||
| # webauthn-rs-core = "0.5.0" | ||
| # webauthn-rs-proto = "0.5.0" | ||
| webauthn-authenticator-rs = { path = "../webauthn-rs/webauthn-authenticator-rs" } |
There was a problem hiding this comment.
We could point at a git commit instead for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, don't merge yet, needs kanidm/webauthn-rs#215; this PR is on top of #1203
This uses the
CtapAuthenticatorimplementation inwebauthn-authenticator-rs. You'll ned to switch to mytransport-authbranch (kanidm/webauthn-rs#215) to get that working.Then you can use it with
--features webauthn-transport(which should disable usingmozillaandwin10).Notes:
I don't know what features
webauthn-authenticator-rsis built with withwebauthn-transportenabled – ideally this should disable bothmozillaandwin10, but Cargo may not offer enough control yet.This could have a better name...
Fixes #