[WIP] Implement Launchpad Mini MK3 Support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangalio
reviewed
Jan 2, 2024
| @@ -28,7 +28,7 @@ fn decode_grid_button(btn: u8) -> Button { | |||
| pub struct Input; | |||
|
|
|||
| impl crate::InputDevice for Input { | |||
| const MIDI_DEVICE_KEYWORD: &'static str = "Launchpad Mini"; | |||
| const MIDI_DEVICE_KEYWORD: &'static str = "Launchpad Mini MIDI"; | |||
There was a problem hiding this comment.
Why this change? The MIDI device detection function (fn guess_port) does .contains() anyways, so a device called "Launchpad Mini MIDI" can be detected with MIDI_DEVICE_KEYWORD "Launchpad Mini" too. I tried to keep those keywords as generic as possible because MIDI device names are different between OSes - some OSes may append " MIDI" to MIDI device names, but other OSes may not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #12
Furthermore
change_layoutto change betweenLayout::ProgrammerandLayout::LiveLayout::Programmer(like done in mk2 implementation) so no need to think about layout