Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uac: add reload_delta parameter #3829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

devopsec
Copy link
Contributor

@devopsec devopsec commented Apr 25, 2024

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Add support for setting a different RPC reload interval than the reg_gc_interval parameter.
This allows the cleanup timer to match the user's re-transmission timeout without constraining RPC reload times to a large interval.

@henningw
Copy link
Contributor

Thanks for the PR. Could you please fix the format by running clang-format on the files and do a force-push to update the individual commit(s)? This check is right now failing.

- add support for setting a different RPC reload interval than
  the reg_gc_interval parameter. This allows the cleanup timer
  to match the user's retransmission timeout without constraining
  RPC reload times to a large interval.
@devopsec
Copy link
Contributor Author

Thanks for the PR. Could you please fix the format by running clang-format on the files and do a force-push to update the individual commit(s)? This check is right now failing.

Fixed formatting, let me know if any other changes are needed.

@devopsec
Copy link
Contributor Author

devopsec commented May 8, 2024

Morning Team,
Checking in on this PR. Can we get this assigned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants