TPE-38 iOS: If resume playback on chromecast using [Play] button of #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
player or player control panel playback starts from the beginning, media info is lost
call play then content plain from start.
ElizaSapir
reviewed
Dec 7, 2016
| @@ -214,7 +214,6 @@ - (GCKCastSession *)currentSession { | |||
|
|
|||
| - (void)setMediaSrc:(NSString *)mediaSrc { | |||
| if (_mediaSrc != nil) { | |||
| _isChangeMedia = YES; | |||
There was a problem hiding this comment.
looks like you dont need here if & else please make sure to merge it to one line
| _isChangeMedia = NO; | ||
| } else { | ||
|
|
||
| [self setVideoUrl:_mediaSrc startPosition:0 autoPlay:YES metaData: nil]; |
There was a problem hiding this comment.
what about this case? when media is not ended and you try to change? did you test it?
There was a problem hiding this comment.
After change media, wait several minutes and press play button this logic will restart playback from 0. I think it's bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player or player control panel playback starts from the beginning,
media info is lost