Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank nodes when parsing dfxp subtitles #1327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgaudaen
Copy link

When parsing DFXP/TTML subtitles to later convert to VTT, blank nodes should be ignored. For instance if you have the following in your dfxp subtitle :

<p begin="00:01:37.437" end="00:01:40.697">
    <span tts:backgroundColor="#000000" tts:color="#ffffff">Sentence 1</span>
    <br></br>
    <span tts:backgroundColor="#000000" tts:color="#ffffff">Sentence 2</span>
</p>

The transformed VTT output looks like :

00:01:37.437 --> 00:01:40.697
Sentence 1
                

                Sentence 2

Whereas the expected result should be :

00:01:37.437 --> 00:01:40.697
Sentence 1
Sentence 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant