Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 3.11 snowboy .so #690

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

jaggzh
Copy link

@jaggzh jaggzh commented Jul 2, 2023

I built a _snowboydetect.so for the new Debian Stable, which uses Python 3.11.

@jaggzh
Copy link
Author

jaggzh commented Jul 2, 2023

re: #689

Copy link

@chirogocki chirogocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my debian12

@Sispheor Sispheor changed the base branch from master to dev July 18, 2023 16:41
@Sispheor
Copy link
Member

OMG just realized that anybody can review and approve by default now 😅.

@Sispheor
Copy link
Member

Test are not passing because your are not rebased on the last dev version. Please do so.

@cprn cprn mentioned this pull request May 27, 2024
@cprn
Copy link

cprn commented May 27, 2024

@jaggzh it'd be awesome if you could do this in your branch:

git switch dev    # switch to `origin/dev` branch locally
git pull          # make sure you have the latest version of that branch
git switch master # switch back to your local `master` branch
git rebase dev    # apply your changes on top of `origin/dev` instead of `origin/master` from which you've initially forked
git push          # update your merge request when you're done

There should be no conflicts so it should be enough to make the PR pass.

In case there are any, you'll have to solve them in your editor before you push, e.g.:

vscode file.ext       # make changes and save
git add file.ext      # tell git to track your change
git rebase --continue # go to next conflict or finish rebasing
git commit            # commit your conflict resolutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants