Skip to content

Commit

Permalink
Remove duplicate pull of token/blockchain docker images
Browse files Browse the repository at this point in the history
With the addition of Stack.VersionManifest, that manifest is now the de facto
source of all images for the stack. There is no need to iterate over the
plugins' Docker service definitions a second time (which are now also generated
from the same VersionManifest).

Fixes hyperledger#119

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
  • Loading branch information
awrichar committed Feb 8, 2022
1 parent 1d1ba52 commit 70a7021
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions internal/stacks/stack_manager.go
Expand Up @@ -455,18 +455,6 @@ func (s *StackManager) PullStack(verbose bool, options *PullOptions) error {
images = append(images, constants.PostgresImageName)
}

// Iterate over all images used by the blockchain provider
for _, service := range s.blockchainProvider.GetDockerServiceDefinitions() {
images = append(images, service.Service.Image)
}

// Iterate over all images used by the tokens provider
for iTok, tp := range s.tokenProviders {
for _, service := range tp.GetDockerServiceDefinitions(iTok) {
images = append(images, service.Service.Image)
}
}

// Use docker to pull every image - retry on failure
for _, image := range images {
s.Log.Info(fmt.Sprintf("pulling '%s", image))
Expand Down

0 comments on commit 70a7021

Please sign in to comment.