Switch to godep, remove vendor directory #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wiki https://github.com/kabukky/journey/wiki/Building-Journey-from-source will need some modifications to install dep after this change. To do this, just run 'brew install dep' or use any of the other options shown in the setup section on https://github.com/golang/dep
|
@kabukky are you still maintaining this? If so, please merge (or close with a comment) on my PR. If not, or if I don't hear from you, I'll keep working on my fork instead. |
Kami-no
added a commit
to Kami-no/journey
that referenced
this pull request
Jan 9, 2020
This abstracts the session handler away from the code, and implements one using SAML. This allows you to use google to authenticate your blog. Google (or another provider) is a lot better because they support two-factor and have a single password that you remember instead of a different one for each website. The only issue remaining here is that there are user preferences and accounts that are in the database that are not used by the SAML integration. Some other cleanup: - Functions that require a session are wrapped by a RequireSession function call. This removes a lot of code in server/admin.go and centralizes the check to make sure you have a session. - Corrects the error status when you fetch something without a session - Stops overwriting the config.json file if you have an error in it. Now, it just refuses to start and tells you why. To configure SAML, you need three things: - Your SAML certificate, in a file, pointed to by SAMLCert in the config - Your SAML key, in a file, pointed to by SAMLKey - The IDP Metadata URL or file, pointed to by SAMLIDPUrl Once you've set things up, set up your SAML IDP to allow access to the app for your domain, or use something like auth0 or Okta to create an entry for it.
This allows these three special files to exist at the top level and get served out of the images directory. One could argue that these should probably be part of the theme, but they aren't.
These extra slashes cause a lot of redirects to happen, and as far as I can tell, they aren't needed for anything, except that some of the javascript doesn't need hardcoded paths.
Added a makefile to quickly rerun all the lint and vet commands needed for this project
This uses the apache log file format, along with formatting options, through the config.json file.
Also update all dependencies to latest versions
Error handling was non-existent before, and although it's better with this commit, it still needs a lot more work.
The router and links weren't working right due to the extra slash removal fix earlier. This corrects the remaining known issues.
This should really be configurable, but the problem is that if the session dies while composing a complicated post, you lose your data. This should really produce a warning.
This change allows you to configure a SMTP server to get email whenever a new post is added. It's intended to go to a mailing list; I'm using a google group. This currently only supports PLAIN auth. It could use some work to support CRAM-MD5 auth.
Seems like I'm diverging enough that it's time for my own namespace.
Post URLs and author URLs were being generated with a trailing slash, which, after a redirect, gets removed.
The database method should only return "published" if it's newly published, not if it's an update to an existing published post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wiki
https://github.com/kabukky/journey/wiki/Building-Journey-from-source
will need some modifications to install dep after this change. To do
this, just run 'brew install dep' or use any of the other options shown
in the setup section on https://github.com/golang/dep