Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

Add LspListInstalled command #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ram02z
Copy link

@ram02z ram02z commented Jul 7, 2021

Closes #92

@kabouzeid
Copy link
Owner

I'm not a fan of the name yet. Are there other suggestions?

@ram02z
Copy link
Author

ram02z commented Jul 10, 2021

I'm not a fan of the name yet. Are there other suggestions?

I could use the name from the original issue, LspList.

@kabouzeid
Copy link
Owner

I'm tending more towards something like :LspListInstalled. The reason is that this plugin doesn't "own" the :Lsp prefix. It's shared with plugins like lspconfig, so the name should clearly indicate which plugin it belongs to.

@ram02z
Copy link
Author

ram02z commented Jul 10, 2021

this plugin doesn't "own" the :Lsp prefix.

How about ListInstalledLsps then?

@AmeerTaweel
Copy link

I think it's better if the command starts with the :Lsp prefix. Because when I want to run an LSP command I would write :Lsp and then hit tab to see the available LSP commands. So I prefer :LspListInstalled over :ListInstalledLsps.

@pocco81
Copy link

pocco81 commented Jul 25, 2021

In my opinion it'd better if it was named :LspList, mostly because of consistency, because as you can see the other lsp related commands have only two camel-cased words, while both :LspListInstalled and :ListInstalledLsp have three each:

image

@kabouzeid
Copy link
Owner

I'm not sure :LspList would be quite right. After all this command will only list lsps installed via LSP install.

:LspListInstalled would be more correct and more obvious which plugin it belongs to.

@ram02z ram02z changed the title Adds LspPrintInstalled command Adds LspListInstalled command Jul 26, 2021
@AmeerTaweel
Copy link

@kabouzeid Any updates on this?

@ram02z ram02z changed the title Adds LspListInstalled command Add LspListInstalled command Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement :LspList to list installed servers
4 participants