Test CI/CD

kaboomshebang · Apr 18, 2023 · 5957459 · 5957459
1 parent 1d7430e
commit 5957459
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -75,7 +75,6 @@ jobs:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
       AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
-      ID: 732701080264
     steps:
       - name: Check out repository code
         uses: actions/checkout@v3
@@ -92,13 +91,8 @@ jobs:
           printf "export AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID\n" > .env
           printf "export AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY\n" >> .env
           printf "export AWS_ACCOUNT_ID=$AWS_ACCOUNT_ID\n" >> .env
-          printf "ID=${{ env.ID }}\n" >> .env
         working-directory: ./lambdas/todos/.aws
-      - run: aws ecr get-login-password --region eu-central-1 | docker login --username AWS --password-stdin $ID.dkr.ecr.eu-central-1.amazonaws.com
       - run: |
-          export AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID
-          export AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY
-          export AWS_ACCOUNT_ID=$AWS_ACCOUNT_ID
           make auth
         working-directory: ./lambdas/todos
       - run: make update

diff --git a/lambdas/todos/Makefile b/lambdas/todos/Makefile
@@ -31,8 +31,8 @@ login:
 	aws sso login
 
 auth:
-	echo $(ID)
-	aws ecr get-login-password --region $(region) | docker login --username AWS --password-stdin $(ecr)
+	aws ecr get-login-password --region $(region) | docker login --username AWS --password-stdin 732701080264.dkr.ecr.eu-central-1.amazonaws.com
+# aws ecr get-login-password --region $(region) | docker login --username AWS --password-stdin $(ecr)
 
 repo:
 	aws ecr create-repository \