App strings reworked #45
Conversation
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_mistakes_check_off">Off</string> | ||
| <string name="pref_mistakes_check_violations">Rules violations</string> | ||
| <string name="pref_mistakes_check_violations">Rule violations</string> | ||
| <string name="pref_mistakes_check_final">With final solution</string> | ||
| <string name="pref_highlight_identical">Highlight identical values</string> | ||
| <string name="pref_highlight_identical_summ">Selection of a value on the board highlights cells with the same value</string> |
There was a problem hiding this comment.
| <string name="pref_highlight_identical_summ">Selection of a value on the board highlights cells with the same value</string> | |
| <string name="pref_highlight_identical_summ">Selection a number on the board highlights similarly numbered cells</string> |
There was a problem hiding this comment.
The actual line is fine for me, no need to shorten it, as it is already simple
app/src/main/res/values/strings.xml
Outdated
| <string name="intro_rules">The goal of the game is to fill all the cells with numbers from 1 to 9. So that the values do not repeat in any column, row or smaller box (3x3)</string> | ||
| <string name="onboard_recommendation_prefs">We recommend that you have a look at the settings tab so that you can customize the application for your needs</string> | ||
| <string name="intro_rules">Use 1–9 to fill all cells—without repetition in any column, row or smaller (3x3) box.</string> | ||
| <string name="onboard_recommendation_prefs">Go through the settings to adjust the game</string> | ||
| <string name="action_start">Start</string> | ||
| <string name="toolbar_undo_description">Undo. Just undo</string> |
There was a problem hiding this comment.
| <string name="toolbar_undo_description">Undo. Just undo</string> | |
| <string name="toolbar_undo_description">Undo. Just undo.</string> |
|
It looks like you haven't played the game that much. Many changed strings would not fit well into the app. The most important thing is to change 'values' to 'numbers', because there's also a 12x12 grid. I think you need to perfect this PR a bit more. |
|
@nvllz I'll see what I can do. Maybe you could put a little dot or an explanation of the issue next to the problematic strings? |
app/src/main/res/values/strings.xml
Outdated
| @@ -40,40 +40,40 @@ | |||
| <string name="pref_input_cell_first">Cell first</string> | |||
| <string name="pref_input_digit_first">Value first</string> | |||
| <string name="pref_delete_stats">Clear all statistics</string> | |||
| <string name="pref_delete_stats_summ">This action will delete all your statistics, saved games and records. It can\'t be undone</string> | |||
| <string name="pref_delete_stats_summ">Deletes stats, saved games and records permanetly.</string> | |||
There was a problem hiding this comment.
It's a dialog box text, so I think it's better to leave it as it is to make the dialog clearer
| <string name="pref_mistakes_check_off">Off</string> | ||
| <string name="pref_mistakes_check_violations">Rules violations</string> | ||
| <string name="pref_mistakes_check_violations">Rule violations</string> | ||
| <string name="pref_mistakes_check_final">With final solution</string> | ||
| <string name="pref_highlight_identical">Highlight identical values</string> |
There was a problem hiding this comment.
As I said, it's better to refer to user input as 'values' because there is also a 12x12 mode where you have both numbers and letters
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_mistakes_check_off">Off</string> | ||
| <string name="pref_mistakes_check_violations">Rules violations</string> | ||
| <string name="pref_mistakes_check_violations">Rule violations</string> | ||
| <string name="pref_mistakes_check_final">With final solution</string> | ||
| <string name="pref_highlight_identical">Highlight identical values</string> | ||
| <string name="pref_highlight_identical_summ">Selection of a value on the board highlights cells with the same value</string> |
There was a problem hiding this comment.
The actual line is fine for me, no need to shorten it, as it is already simple
app/src/main/res/values/strings.xml
Outdated
| @@ -88,46 +88,46 @@ | |||
| <string name="action_show_mine_sudoku">Show mine</string> | |||
| <string name="onboard_title">Welcome</string> | |||
| <string name="intro_what_is_sudoku">A classic sudoku looks as follows</string> | |||
| <string name="intro_rules">The goal of the game is to fill all the cells with numbers from 1 to 9. So that the values do not repeat in any column, row or smaller box (3x3)</string> | |||
| <string name="onboard_recommendation_prefs">We recommend that you have a look at the settings tab so that you can customize the application for your needs</string> | |||
| <string name="intro_rules">Use 1–9 to fill all cells—without repetition in any column, row or smaller (3x3) box.</string> | |||
There was a problem hiding this comment.
It is a tutorial description and the actual line is perfectly fine. Gives newbies more context
app/src/main/res/values/strings.xml
Outdated
| <string name="intro_rules">The goal of the game is to fill all the cells with numbers from 1 to 9. So that the values do not repeat in any column, row or smaller box (3x3)</string> | ||
| <string name="onboard_recommendation_prefs">We recommend that you have a look at the settings tab so that you can customize the application for your needs</string> | ||
| <string name="intro_rules">Use 1–9 to fill all cells—without repetition in any column, row or smaller (3x3) box.</string> | ||
| <string name="onboard_recommendation_prefs">Go through the settings to adjust the game</string> |
There was a problem hiding this comment.
I would add 'details' at the end
app/src/main/res/values/strings.xml
Outdated
| <string name="move_games_to_folder_subtitle">Select the folder to which you want to move the selected games</string> | ||
| <string name="pref_cross_highlight_subtitle">Highlight some boxes on the board</string> | ||
| <string name="move_games_to_folder_subtitle">Select a folder to move the selected games to</string> | ||
| <string name="pref_cross_highlight_subtitle">Highlight some boxen on the board</string> |
There was a problem hiding this comment.
Boxen? The actual line is correct
There was a problem hiding this comment.
Plural of "box".
There was a problem hiding this comment.
Unfortunately, it's "boxes" in English
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_crash_reporting">Crash reporting</string> | ||
| <string name="pref_crash_reporting_subtitle">Help us fix bugs. App doesn\'t send logs by itself, you will be prompted to send a crash report by email</string> | ||
| <string name="pref_crash_reporting_subtitle">Help us fix bugs. No logs leave the device unless sent by e-mail.</string> |
There was a problem hiding this comment.
I'd prefer email. And.. delete trailing period
app/src/main/res/values/strings.xml
Outdated
| <string name="nav_bar_home">Home</string> | ||
| <string name="nav_bar_more">More</string> | ||
| <string name="new_game">New game</string> | ||
| <string name="dialog_new_game">Game in progress</string> | ||
| <string name="dialog_new_game_text">You have an unfinished game, do you really want to start a new one?</string> | ||
| <string name="dialog_new_game_text">End unfinished game to start a new one?</string> |
There was a problem hiding this comment.
Maybe this way?
You have a game in progress. Want to start a new?
Because starting a new game doesn't end the current game. You can come back at any time, and the dialog must be informative
| <string name="pref_mistakes_check_off">Off</string> | ||
| <string name="pref_mistakes_check_violations">Rules violations</string> | ||
| <string name="pref_mistakes_check_violations">Rule violations</string> | ||
| <string name="pref_mistakes_check_final">With final solution</string> | ||
| <string name="pref_highlight_identical">Highlight identical values</string> |
There was a problem hiding this comment.
| <string name="pref_highlight_identical">Highlight identical values</string> | |
| <string name="pref_highlight_identical">Highlight repeated values</string> |
(same as the explanation)
app/src/main/res/values/strings.xml
Outdated
| <string name="sudoku_rules_mistakes_highlight">Highlight mistakes</string> | ||
| <string name="sudoku_rules_mistakes_explanation">The first mistake is two 2s in the sixth box. Remember the rule that there can\'t be double values in a box? The second mistake is the number 6 in row 2, column 8 (R2C8), because there is already a 6 in that column in R5C8</string> | ||
| <string name="sudoku_rules_mistakes_explanation">2 can not be repeated within a (3x3) box? There can only be one 6 in each row.</string> |
There was a problem hiding this comment.
One button to highlight each of these, with the border of the respective box and row highlighted works better(?).
The notation can be explained in a different category, as it isn't crucial for beginners.
There was a problem hiding this comment.
This string is completely wrong. Starting a line with a number looks weird, and the whole sentence is out of context. It's not friendly at all, and I wouldn't know what to do with such a raw short description if I was a complete newbie. Please don't try to make things as simple as possible when it's not necessary
There was a problem hiding this comment.
The idea is to present pertinent information, without it being a wall of text.
Only values are cited in numbers, so it is easy to scan for them visually.
I am a beginner and I had trouble figuring out the guide, as there is so much new info presented all at once.
For this, it isn't clear where the boxes are, the latter error doesn't get to the point. The notation cited with and without brackets doesn't help.
There was a problem hiding this comment.
It's clear where the boxes are, as they're actually described at the top of the 'Basics' section. And it's not really a wall of text. It's sort of a way of putting sentences together, and I think it's a really good description at the moment
app/src/main/res/values/strings.xml
Outdated
| <string name="learn_basic_6">As a result, we are left with only one cell that can contain the number 4. This is cell R1C3</string> | ||
| <string name="learn_basic_1">Selecting the seventh box, one finds it has four cells pre-filled</string> | ||
| <string name="learn_basic_2">8 in row four, column three (R4C3) blocks the entire column in our (3x3) box, sp 8 must go elsewhere.</string> | ||
| <string name="learn_basic_3">8 (in R7C5) blocks the entire row in our box</string> |
There was a problem hiding this comment.
| <string name="learn_basic_3">8 (in R7C5) blocks the entire row in our box</string> | |
| <string name="learn_basic_3">This 8 blocks the entire row in the box.</string> |
There was a problem hiding this comment.
It's not a good change. Really, no need to shorten everything bro if something is correct
There was a problem hiding this comment.
Idk. I spent too much time on these lines. Many of them are grammatically incorrect, and you look like you don't mind changing them. If I were kaajo, I wouldn't want to change the app that much, because it looks like you were forced to make it as simple as possible. It's not the most important thing as the app is fully functional right now. I commented on many of your suggestions, but you didn't want to change many of them. I'm tired of checking it multiple times, let's either use my suggestions or leave it as it is. Because it will look really weird in many places, especially where lines start a sentence with a bare number. LibreSudoku was designed from the beginning to be user friendly, and this pull request would somehow change that. Sorry, unless you make it like I said I personally can't approve it. Too many errors, too less positive changes. And you seem to skip my suggestions :/
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_remaining_uses">Remaining uses</string> | ||
| <string name="pref_remaining_uses_summ">The number of remaining uses of a value is displayed on the keyboard</string> | ||
| <string name="pref_remaining_uses_summ">The number of each unplaced value is displayed on the keyboard.</string> |
There was a problem hiding this comment.
It's a bit of a misleading description. I'd leave it the way it is now
| <string name="intro_what_is_sudoku">A classic sudoku looks as follows</string> | ||
| <string name="intro_rules">Use 1–9 to fill all cells—without repetition in any column, row or smaller (3x3) box.</string> | ||
| <string name="onboard_recommendation_prefs">Go through the settings to adjust the game</string> | ||
| <string name="intro_what_is_sudoku">A classic sudoku</string> |
There was a problem hiding this comment.
It's a short tutorial for the game, so I don't know why you want to shorten it like that
There was a problem hiding this comment.
The actual invocation of how it looks is ironically farther removed from where it is presented visually by both superfluous info and the text below it.
The game is translated into Russian, which often overshoots boundaries this way.
https://developer.android.com/docs/quality-guidelines/core-app-quality
The app displays text and text blocks in an acceptable manner for each of the app’s supported languages. Composition is acceptable in all supported form factors.No cut-off letters or words are visible. No improper word wraps within buttons or icons are visible. There is sufficient spacing between text and surrounding elements.
The end result (considering all changes) I think induces less stress.
It is a pivotal point in not losing userbase.
There was a problem hiding this comment.
It's a learning point, so you read the text and look at the grid and come back to the description to know what's going on. This line serves as a short introduction, that's why I see it as it is now
There was a problem hiding this comment.
I want to do as little of that as possible, in keeping with the stated intent.
There was a problem hiding this comment.
Your links were about buttons, dialogs, etc. Not about game tutorials or other descriptions. They don't always have to be as short as possible. They need to be informative and user friendly
There was a problem hiding this comment.
The total here is important, because these are the grimmest strings AFAICT.
If at all anyone complains that there isn't a connection between what it says and what is shown,
it can easily be changed back.
What is the entire thing trying to do, and is it doing anything else is where I can.
Ultimate length of text is only correlated.
There can be visual clue strings for impaired users. Like the ARIA HINT ones, but for Android.
https://support.google.com/accessibility/android/answer/7158690?hl=en
If the element is associated with an action, describe the action, not the graphical representation.
app/src/main/res/values/strings.xml
Outdated
| <string name="toolbar_erase_description">Removes a number or all notes from the selected cell</string> | ||
| <string name="toolbar_undo_description">Undo. Just undo.</string> | ||
| <string name="toolbar_notes_description">Note mode (pencil marks)</string> | ||
| <string name="toolbar_hint_description">Solves the selected cell. (Can be turned off.)</string> |
There was a problem hiding this comment.
I don't like periods inside brackets
There was a problem hiding this comment.
I would remove that sentence entirely. "Solve selected cell." makes sense to me.
I agree it looks out of context, but then again maybe that is because it is.
Semantically it is correct.
https://www.grammarbook.com/punctuation/parens.asp
Periods go inside parentheses only if an entire sentence is inside the parentheses.
There was a problem hiding this comment.
Yeah, let it be 'Solve selected cell'. And no periods here, please
app/src/main/res/values/strings.xml
Outdated
| <string name="learn_basic_6">As a result, we are left with only one cell that can contain the number 4. This is cell R1C3</string> | ||
| <string name="learn_basic_1">Selecting the seventh box, one finds it has four cells pre-filled</string> | ||
| <string name="learn_basic_2">8 in row four, column three (R4C3) blocks the entire column in our (3x3) box, sp 8 must go elsewhere.</string> | ||
| <string name="learn_basic_3">8 (in R7C5) blocks the entire row in our box</string> |
There was a problem hiding this comment.
It's not a good change. Really, no need to shorten everything bro if something is correct
app/src/main/res/values/strings.xml
Outdated
| <string name="learn_hidden_pairs_1">Hidden pairs are almost the same as naked pairs, the only difference being that they are hidden among the others. These two cells have something in common, they can hold the numbers 6 and 9, and these are the only two squares here where they can stand on</string> | ||
| <string name="learn_hidden_pairs_2">You can conclude that these two cells contain only these two numbers and not the others. So you can remove unnecessary markers from these cells. As with naked pairs, this works the same way with columns and rows</string> | ||
| <string name="learn_hidden_pairs_1">Hidden pairs are almost the same as naked ones, but are hidden among the others. These two cells have something in common, they can hold 6 and 9, and these are the only two squares here where they can stand on</string> | ||
| <string name="learn_hidden_pairs_2">Thus, these two cells contain only these two values and not the others. Unnecessary markers can be removed from these cells. As with naked pairs, the same applies to columns and rows.</string> |
There was a problem hiding this comment.
Looks nice. But I'd shorten it and fix gramatically
Thus, these two cells contain only these two values, and unncecessary markers can be removed from these cells. As with naked pairs, the same applies to columns and rows
app/src/main/res/values/strings.xml
Outdated
| <string name="export_string_title">Export as string</string> | ||
| <string name="export_string_copy">Copy</string> | ||
| <string name="export_string_state_copied">Copied</string> | ||
| <string name="export_string_state_error">Error</string> | ||
| <string name="filter_all">All</string> | ||
| <string name="filter_completed">Completed</string> | ||
| <string name="filter_in_progress">In progress</string> | ||
| <string name="filter_in_progress">Underway</string> |
app/src/main/res/values/strings.xml
Outdated
| <string name="nav_bar_home">Home</string> | ||
| <string name="nav_bar_more">More</string> | ||
| <string name="new_game">New game</string> | ||
| <string name="dialog_new_game">Game in progress</string> | ||
| <string name="dialog_new_game_text">You have an unfinished game, do you really want to start a new one?</string> | ||
| <string name="dialog_new_game_text">Pause this game and start a new one?</string> |
There was a problem hiding this comment.
'Pause' is a little misleading here. It's a main screen dialog, so you don't have the game in front of you. And you refer to it as if you were starting from the inside of an ongoing game
app/src/main/res/values/strings.xml
Outdated
| <string name="nav_bar_home">Home</string> | ||
| <string name="nav_bar_more">More</string> | ||
| <string name="new_game">New game</string> | ||
| <string name="dialog_new_game">Game in progress</string> | ||
| <string name="dialog_new_game_text">You have an unfinished game, do you really want to start a new one?</string> | ||
| <string name="dialog_new_game_text">Continue, or start a new game?</string> |
There was a problem hiding this comment.
Please tell me one thing. Why do you want to do it your way at all costs? It seems like you don't even know when the dialog is displayed :/
There was a problem hiding this comment.
I didn't and I got it wrong. This I thought would be better for where it is.
There was a problem hiding this comment.
You don't have the option to continue from this dialog, so this is not the correct way to describe the action. I said somewhere earlier how to name it, and you should go that way, I think
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_crash_reporting">Crash reporting</string> | ||
| <string name="pref_crash_reporting_subtitle">Help us fix bugs. App doesn\'t send logs by itself, you will be prompted to send a crash report by email</string> | ||
| <string name="pref_crash_reporting_subtitle">Ask to submit bug reports via e-mail.</string> |
There was a problem hiding this comment.
Wrong way to describe it. I told you how to do it, but yeah.. you don't mind
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_mistakes_check_final">With final solution</string> | ||
| <string name="pref_highlight_identical">Highlight identical values</string> | ||
| <string name="pref_highlight_identical_summ">Selection of a value on the board highlights cells with the same value</string> | ||
| <string name="pref_highlight_identical">Highlight repeated values</string> |
There was a problem hiding this comment.
It's an option to highlight the same values across the board. So they are not necessarily repeated in the 3x3 box as this message implies. Please undo this change to match the context
app/src/main/res/values/strings.xml
Outdated
| <string name="pref_position_lines">Position lines</string> | ||
| <string name="pref_position_lines_summ">The row and column of the selected cell are highlighted</string> | ||
| <string name="pref_auto_erase_notes">Auto erase notes</string> | ||
| <string name="pref_position_lines">Positional lines</string> |
There was a problem hiding this comment.
'Position lines' is more correct
It is unclear what "Ascending" / "Descending" refers to.