Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm - Grafana Dashboard #967

Merged
merged 1 commit into from
May 28, 2024

Conversation

SchoolGuy
Copy link
Contributor

@SchoolGuy SchoolGuy commented May 9, 2024

Summary

This PR adds a Grafana dashboard that exposes the metrics that both the operator and the pushgateway are exposing.

This is related (but not fixing) #860

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@SchoolGuy SchoolGuy requested a review from a team as a code owner May 9, 2024 10:39
@SchoolGuy SchoolGuy requested review from zugao and lieneluksika and removed request for a team May 9, 2024 10:39
@zugao zugao requested a review from Kidswiss May 10, 2024 06:41
@Kidswiss
Copy link
Contributor

@SchoolGuy

Looks like helm is not happy with the template :/ It tries to interpret some grafana dashboard variables as helm variables. You probably have to add some sort of escaping to prevent that.

@TheBigLee TheBigLee self-requested a review May 27, 2024 14:48
@TheBigLee TheBigLee force-pushed the add-grafana-dashboard branch 4 times, most recently from 0c6eb81 to 5042b52 Compare May 28, 2024 08:33
Signed-off-by: Enno Gotthold <matrixfueller@gmail.com>
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee merged commit d996d16 into k8up-io:master May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants